Add code

tests/unit/config.test.ts

@@ -0,0 +1,141 @@
+/**
+ * Unit tests for TokenConfigLoader
+ */
+
+import { describe, it, expect, vi, beforeEach, afterEach } from 'vitest';
+import { TokenConfigLoader, TokenConfig, DefaultConfigLoader, DefaultConfig } from '../../src/config.js';
+
+describe('TokenConfigLoader', () => {
+  const originalEnv = { ...process.env };
+
+  beforeEach(() => {
+    process.env = { ...originalEnv };
+    delete process.env.BITBUCKET_MCP_TOKEN;
+    delete process.env.DEFAULT_WORKSPACE;
+    delete process.env.DEFAULT_REPO;
+  });
+
+  afterEach(() => {
+    process.env = originalEnv;
+    vi.restoreAllMocks();
+  });
+
+  describe('token validation', () => {
+    it('should accept valid tokens (alphanumeric with special chars)', () => {
+      const validPattern = /^[A-Za-z0-9=._-]+$/;
+      
+      expect(validPattern.test('abc123def45678901234567')).toBe(true);
+      expect(validPattern.test('ATBB1234567890abcdefgh')).toBe(true);
+      expect(validPattern.test('Bearer_token.with=chars12')).toBe(true);
+        expect(validPattern.test('a'.repeat(20))).toBe(true);
+    });
+
+    it('should reject tokens that are too short', () => {
+      const shortToken = 'abc123';
+      expect(shortToken.length).toBeLessThan(20);
+      });
+
+    it('should reject tokens with invalid characters', () => {
+      const invalidToken = 'token with spaces!@#$%';
+      const validPattern = /^[A-Za-z0-9=._-]+$/;
+      expect(validPattern.test(invalidToken)).toBe(false);
+    });
+  });
+
+  describe('environment variable loading', () => {
+    it('should load token from BITBUCKET_MCP_TOKEN env var', async () => {
+      process.env.BITBUCKET_MCP_EMAIL = 'test@example.com';
+      process.env.BITBUCKET_MCP_TOKEN = 'valid_test_token_12345678901234567';
+
+      const config = await TokenConfigLoader.load();
+
+      expect(config.token).toBe('valid_test_token_12345678901234567');
+      expect(config.source).toBe('env');
+    });
+  });
+
+  describe('TokenConfig interface', () => {
+    it('should return correct config structure for env source', async () => {
+      process.env.BITBUCKET_MCP_TOKEN = 'test_token_12345678901234567';
+
+      const config = await TokenConfigLoader.load();
+
+      expect(config).toHaveProperty('token');
+      expect(config).toHaveProperty('source');
+      expect(['env', 'dotenv', 'prompt']).toContain(config.source);
+    });
+  });
+});
+
+describe('DefaultConfigLoader', () => {
+  const originalEnv = { ...process.env };
+
+  beforeEach(() => {
+    process.env = { ...originalEnv };
+    delete process.env.DEFAULT_WORKSPACE;
+    delete process.env.DEFAULT_REPO;
+  });
+
+  afterEach(() => {
+    process.env = originalEnv;
+  });
+
+  describe('load', () => {
+    it('should return null values when env vars are not set', () => {
+      const config = DefaultConfigLoader.load();
+
+      expect(config.workspace).toBeNull();
+      expect(config.repo).toBeNull();
+    });
+
+    it('should return workspace and repo from env vars when set', () => {
+      process.env.DEFAULT_WORKSPACE = 'my-workspace';
+      process.env.DEFAULT_REPO = 'my-repo';
+
+      const config = DefaultConfigLoader.load();
+
+      expect(config.workspace).toBe('my-workspace');
+      expect(config.repo).toBe('my-repo');
+    });
+
+    it('should return partial config when only workspace is set', () => {
+      process.env.DEFAULT_WORKSPACE = 'only-workspace';
+
+      const config = DefaultConfigLoader.load();
+
+      expect(config.workspace).toBe('only-workspace');
+      expect(config.repo).toBeNull();
+    });
+
+    it('should return partial config when only repo is set', () => {
+      process.env.DEFAULT_REPO = 'only-repo';
+
+      const config = DefaultConfigLoader.load();
+
+      expect(config.workspace).toBeNull();
+      expect(config.repo).toBe('only-repo');
+    });
+  });
+
+  describe('getWorkspace', () => {
+    it('should return null when DEFAULT_WORKSPACE is not set', () => {
+      expect(DefaultConfigLoader.getWorkspace()).toBeNull();
+    });
+
+    it('should return workspace value when set', () => {
+      process.env.DEFAULT_WORKSPACE = 'test-workspace';
+      expect(DefaultConfigLoader.getWorkspace()).toBe('test-workspace');
+    });
+  });
+
+  describe('getRepo', () => {
+    it('should return null when DEFAULT_REPO is not set', () => {
+      expect(DefaultConfigLoader.getRepo()).toBeNull();
+    });
+
+    it('should return repo value when set', () => {
+      process.env.DEFAULT_REPO = 'test-repo';
+      expect(DefaultConfigLoader.getRepo()).toBe('test-repo');
+    });
+  });
+});

tests/unit/router.test.ts

@@ -0,0 +1,444 @@
+/**
+ * Unit tests for BitbucketRouter
+ */
+
+import { describe, it, expect, vi, beforeEach } from 'vitest';
+import { BitbucketRouter, ToolResult } from '../../src/router.js';
+
+// Mock the BitbucketClient
+vi.mock('../../src/bitbucket-client.js', () => {
+  return {
+    BitbucketClient: vi.fn().mockImplementation(() => ({
+      listPullRequests: vi.fn().mockResolvedValue([
+        { id: 1, title: 'Test PR 1', state: 'OPEN' },
+        { id: 2, title: 'Test PR 2', state: 'MERGED' }
+      ]),
+      getPullRequest: vi.fn().mockResolvedValue({
+        id: 1,
+        title: 'Test PR',
+        state: 'OPEN',
+        source: { branch: { name: 'feature' } },
+        destination: { branch: { name: 'main' } }
+      }),
+      getPullRequestStatus: vi.fn().mockResolvedValue({
+        id: 1,
+        title: 'Test PR',
+        state: 'OPEN',
+        status: 'NORMAL'
+      }),
+      getPullRequestActivities: vi.fn().mockResolvedValue({
+        values: [{ action: 'OPEN' }]
+      }),
+      getPullRequestChanges: vi.fn().mockResolvedValue({
+        values: [{ type: 'modified', path: 'src/test.ts' }]
+      }),
+      getPullRequestComments: vi.fn().mockResolvedValue({
+        values: [{ id: 1, content: { raw: 'Test comment' } }]
+      }),
+      getPullRequestComment: vi.fn().mockResolvedValue({
+        id: 1,
+        content: { raw: 'Test comment' }
+      }),
+      getPullRequestCommits: vi.fn().mockResolvedValue({
+        values: [{ hash: 'abc123' }]
+      }),
+      getPullRequestDiff: vi.fn().mockResolvedValue({
+        diff: '--- test.ts\n+++ test.ts\n@@ -1 +1 @@'
+      }),
+      getPullRequestPatch: vi.fn().mockResolvedValue({
+        patch: '--- original\n+++ modified'
+      }),
+      getPullRequestParticipants: vi.fn().mockResolvedValue({
+        values: [{ user: { display_name: 'Test User' } }]
+      }),
+      getPullRequestReviewers: vi.fn().mockResolvedValue([
+        { user: { display_name: 'Reviewer 1' } }
+      ]),
+      getPullRequestTasks: vi.fn().mockResolvedValue({
+        values: []
+      }),
+      getPullRequestTaskCount: vi.fn().mockResolvedValue({ count: 0 }),
+      getFullPullRequest: vi.fn().mockResolvedValue({
+        id: 1,
+        title: 'Test PR',
+        description: 'Test description'
+      })
+    }))
+  };
+});
+
+describe('BitbucketRouter', () => {
+  let router: BitbucketRouter;
+  const originalEnv = { ...process.env };
+
+  beforeEach(() => {
+    process.env = { ...originalEnv };
+    delete process.env.DEFAULT_WORKSPACE;
+    delete process.env.DEFAULT_REPO;
+    router = new BitbucketRouter();
+  });
+
+  afterEach(() => {
+    process.env = originalEnv;
+  });
+
+  describe('list_pull_requests', () => {
+    it('should return pull requests for valid parameters', async () => {
+      const result = await router.executeTool('list_pull_requests', {
+        workspace: 'test-workspace',
+        repository: 'test-repo'
+      }) as ToolResult;
+
+      expect(result.success).toBe(true);
+      expect(result.data).toHaveProperty('pull_requests');
+      expect(result.data.pull_requests).toHaveLength(2);
+    });
+
+    it('should fail without workspace', async () => {
+      const result = await router.executeTool('list_pull_requests', {
+        repository: 'test-repo'
+      }) as ToolResult;
+
+      expect(result.success).toBe(false);
+      expect(result.error).toContain('Missing required parameters');
+    });
+
+    it('should fail without repository', async () => {
+      const result = await router.executeTool('list_pull_requests', {
+        workspace: 'test-workspace'
+      }) as ToolResult;
+
+      expect(result.success).toBe(false);
+      expect(result.error).toContain('Missing required parameters');
+    });
+
+    it('should accept "repo" as alias for "repository"', async () => {
+      const result = await router.executeTool('list_pull_requests', {
+        workspace: 'test-workspace',
+        repo: 'test-repo'
+      }) as ToolResult;
+
+      expect(result.success).toBe(true);
+    });
+
+    it('should use DEFAULT_WORKSPACE when workspace is not provided', async () => {
+      process.env.DEFAULT_WORKSPACE = 'default-workspace';
+      process.env.DEFAULT_REPO = 'default-repo';
+
+      const result = await router.executeTool('list_pull_requests', {}) as ToolResult;
+
+      expect(result.success).toBe(true);
+    });
+
+    it('should use DEFAULT_REPO when repository is not provided', async () => {
+      process.env.DEFAULT_REPO = 'default-repo';
+
+      const result = await router.executeTool('list_pull_requests', {
+        workspace: 'test-workspace'
+      }) as ToolResult;
+
+      expect(result.success).toBe(true);
+    });
+
+    it('should use both DEFAULT_WORKSPACE and DEFAULT_REPO when neither is provided', async () => {
+      process.env.DEFAULT_WORKSPACE = 'default-workspace';
+      process.env.DEFAULT_REPO = 'default-repo';
+
+      const result = await router.executeTool('list_pull_requests', {}) as ToolResult;
+
+      expect(result.success).toBe(true);
+    });
+
+    it('should prefer explicit params over defaults', async () => {
+      process.env.DEFAULT_WORKSPACE = 'default-workspace';
+      process.env.DEFAULT_REPO = 'default-repo';
+
+      const result = await router.executeTool('list_pull_requests', {
+        workspace: 'explicit-workspace',
+        repository: 'explicit-repo'
+      }) as ToolResult;
+
+      expect(result.success).toBe(true);
+    });
+
+    it('should still fail when no workspace and no default available', async () => {
+      const result = await router.executeTool('list_pull_requests', {
+        repository: 'test-repo'
+      }) as ToolResult;
+
+      expect(result.success).toBe(false);
+      expect(result.error).toContain('Missing required parameters');
+    });
+
+    it('should still fail when no repository and no default available', async () => {
+      const result = await router.executeTool('list_pull_requests', {
+        workspace: 'test-workspace'
+      }) as ToolResult;
+
+      expect(result.success).toBe(false);
+      expect(result.error).toContain('Missing required parameters');
+    });
+  });
+
+  describe('get_pull_request', () => {
+    it('should return pull request for valid parameters', async () => {
+      const result = await router.executeTool('get_pull_request', {
+        workspace: 'test-workspace',
+        repository: 'test-repo',
+        pullRequestId: 1
+      }) as ToolResult;
+
+      expect(result.success).toBe(true);
+      expect(result.data).toHaveProperty('id', 1);
+    });
+
+    it('should accept pullRequestId as pr_id', async () => {
+      const result = await router.executeTool('get_pull_request', {
+        workspace: 'test-workspace',
+        repository: 'test-repo',
+        pr_id: 1
+      }) as ToolResult;
+
+      expect(result.success).toBe(true);
+    });
+
+    it('should fail with invalid pullRequestId', async () => {
+      const result = await router.executeTool('get_pull_request', {
+        workspace: 'test-workspace',
+        repository: 'test-repo',
+        pullRequestId: 'invalid'
+      }) as ToolResult;
+
+      expect(result.success).toBe(false);
+    });
+  });
+
+  describe('get_pull_request_activities', () => {
+    it('should return activities for valid PR', async () => {
+      const result = await router.executeTool('get_pull_request_activities', {
+        workspace: 'test-workspace',
+        repository: 'test-repo',
+        pullRequestId: 1
+      }) as ToolResult;
+
+      expect(result.success).toBe(true);
+      expect(result.data).toHaveProperty('values');
+    });
+
+    it('should accept pagination parameters', async () => {
+      const result = await router.executeTool('get_pull_request_activities', {
+        workspace: 'test-workspace',
+        repository: 'test-repo',
+        pullRequestId: 1,
+        limit: 10,
+        start: 0
+      }) as ToolResult;
+
+      expect(result.success).toBe(true);
+    });
+  });
+
+  describe('get_pull_request_changes', () => {
+    it('should return changes for valid PR', async () => {
+      const result = await router.executeTool('get_pull_request_changes', {
+        workspace: 'test-workspace',
+        repository: 'test-repo',
+        pullRequestId: 1
+      }) as ToolResult;
+
+      expect(result.success).toBe(true);
+      expect(result.data).toHaveProperty('values');
+    });
+  });
+
+  describe('get_pull_request_comments', () => {
+    it('should return comments for valid PR', async () => {
+      const result = await router.executeTool('get_pull_request_comments', {
+        workspace: 'test-workspace',
+        repository: 'test-repo',
+        pullRequestId: 1
+      }) as ToolResult;
+
+      expect(result.success).toBe(true);
+      expect(result.data).toHaveProperty('values');
+    });
+  });
+
+  describe('get_pull_request_comment', () => {
+    it('should return specific comment', async () => {
+      const result = await router.executeTool('get_pull_request_comment', {
+        workspace: 'test-workspace',
+        repository: 'test-repo',
+        pullRequestId: 1,
+        commentId: 1
+      }) as ToolResult;
+
+      expect(result.success).toBe(true);
+      expect(result.data).toHaveProperty('id', 1);
+    });
+
+    it('should fail without commentId', async () => {
+      const result = await router.executeTool('get_pull_request_comment', {
+        workspace: 'test-workspace',
+        repository: 'test-repo',
+        pullRequestId: 1
+      }) as ToolResult;
+
+      expect(result.success).toBe(false);
+    });
+  });
+
+  describe('get_pull_request_commits', () => {
+    it('should return commits for valid PR', async () => {
+      const result = await router.executeTool('get_pull_request_commits', {
+        workspace: 'test-workspace',
+        repository: 'test-repo',
+        pullRequestId: 1
+      }) as ToolResult;
+
+      expect(result.success).toBe(true);
+      expect(result.data).toHaveProperty('values');
+    });
+  });
+
+  describe('get_pull_request_diff', () => {
+    it('should return diff for valid PR', async () => {
+      const result = await router.executeTool('get_pull_request_diff', {
+        workspace: 'test-workspace',
+        repository: 'test-repo',
+        pullRequestId: 1
+      }) as ToolResult;
+
+      expect(result.success).toBe(true);
+      expect(result.data).toHaveProperty('diff');
+    });
+
+    it('should accept path and context parameters', async () => {
+      const result = await router.executeTool('get_pull_request_diff', {
+        workspace: 'test-workspace',
+        repository: 'test-repo',
+        pullRequestId: 1,
+        path: 'src/test.ts',
+        context: 3
+      }) as ToolResult;
+
+      expect(result.success).toBe(true);
+    });
+  });
+
+  describe('get_pull_request_patch', () => {
+    it('should return patch for valid PR', async () => {
+      const result = await router.executeTool('get_pull_request_patch', {
+        workspace: 'test-workspace',
+        repository: 'test-repo',
+        pullRequestId: 1
+      }) as ToolResult;
+
+      expect(result.success).toBe(true);
+      expect(result.data).toHaveProperty('patch');
+    });
+  });
+
+  describe('get_pull_request_participants', () => {
+    it('should return participants for valid PR', async () => {
+      const result = await router.executeTool('get_pull_request_participants', {
+        workspace: 'test-workspace',
+        repository: 'test-repo',
+        pullRequestId: 1
+      }) as ToolResult;
+
+      expect(result.success).toBe(true);
+      expect(result.data).toHaveProperty('values');
+    });
+  });
+
+  describe('get_pull_request_reviewers', () => {
+    it('should return reviewers for valid PR', async () => {
+      const result = await router.executeTool('get_pull_request_reviewers', {
+        workspace: 'test-workspace',
+        repository: 'test-repo',
+        pullRequestId: 1
+      }) as ToolResult;
+
+      expect(result.success).toBe(true);
+    });
+  });
+
+  describe('get_pull_request_status', () => {
+    it('should return status for valid PR', async () => {
+      const result = await router.executeTool('get_pull_request_status', {
+        workspace: 'test-workspace',
+        repository: 'test-repo',
+        pullRequestId: 1
+      }) as ToolResult;
+
+      expect(result.success).toBe(true);
+      expect(result.data).toHaveProperty('state');
+    });
+  });
+
+  describe('get_pull_request_tasks', () => {
+    it('should return tasks for valid PR', async () => {
+      const result = await router.executeTool('get_pull_request_tasks', {
+        workspace: 'test-workspace',
+        repository: 'test-repo',
+        pullRequestId: 1
+      }) as ToolResult;
+
+      expect(result.success).toBe(true);
+    });
+  });
+
+  describe('get_pull_request_task_count', () => {
+    it('should return task count for valid PR', async () => {
+      const result = await router.executeTool('get_pull_request_task_count', {
+        workspace: 'test-workspace',
+        repository: 'test-repo',
+        pullRequestId: 1
+      }) as ToolResult;
+
+      expect(result.success).toBe(true);
+    });
+  });
+
+  describe('get_full_pull_request', () => {
+    it('should return full PR details', async () => {
+      const result = await router.executeTool('get_full_pull_request', {
+        workspace: 'test-workspace',
+        repository: 'test-repo',
+        pullRequestId: 1
+      }) as ToolResult;
+
+      expect(result.success).toBe(true);
+      expect(result.data).toHaveProperty('id');
+      expect(result.data).toHaveProperty('description');
+    });
+  });
+
+  describe('unknown tool', () => {
+    it('should return error for unknown tool', async () => {
+      const result = await router.executeTool('unknown_tool', {}) as ToolResult;
+
+      expect(result.success).toBe(false);
+      expect(result.error).toContain('Unknown tool');
+    });
+  });
+
+  describe('error handling', () => {
+    it('should handle API errors gracefully', async () => {
+      // Create router with a mock that throws
+      const errorRouter = new BitbucketRouter();
+      
+      const result = await errorRouter.executeTool('list_pull_requests', {
+        workspace: 'test-workspace',
+        repository: 'test-repo'
+      }) as ToolResult;
+
+      // With our mock, this should succeed, but error cases should return proper format
+      if (!result.success) {
+        expect(result.error).toBeDefined();
+        expect(typeof result.error).toBe('string');
+      }
+    });
+  });
+});